generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(testing-sdk): implement callback token generation and processing #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c5ec84 to
e969c7b
Compare
bchampp
reviewed
Nov 9, 2025
src/aws_durable_execution_sdk_python_testing/checkpoint/validators/operations/callback.py
Show resolved
Hide resolved
bchampp
reviewed
Nov 9, 2025
bchampp
reviewed
Nov 9, 2025
bchampp
reviewed
Nov 9, 2025
src/aws_durable_execution_sdk_python_testing/checkpoint/processors/base.py
Outdated
Show resolved
Hide resolved
bchampp
previously approved these changes
Nov 11, 2025
yaythomas
requested changes
Nov 11, 2025
Member
yaythomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggestions, but this is looking very good, thank you!
src/aws_durable_execution_sdk_python_testing/checkpoint/processors/base.py
Outdated
Show resolved
Hide resolved
src/aws_durable_execution_sdk_python_testing/checkpoint/processors/callback.py
Outdated
Show resolved
Hide resolved
- Add CallbackToken generation in callback processor with observer integration - Implement SendCallbackSuccess, SendCallbackFailure, and SendCallbackHeartbeat - Add callback operation lookup and completion methods to execution - Ensure unique token generation across executions
bchampp
previously approved these changes
Nov 12, 2025
yaythomas
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #41
closes #42
closes #43
closes #44
Description of changes:
Dependencies
If this PR requires testing against a specific branch of the Python Language SDK (e.g., for unreleased changes), uncomment and specify the branch below. Otherwise, leave commented to use the main branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.